jester/zlh-grind
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases Wiki Activity

Document hardcoded IPs in zlh-agent including compiled constant in update.go

Browse Source
This commit is contained in:
jester 2026-03-31 12:07:08 +00:00
parent 64ba5e3bb6
commit 4fad12c8bc
1 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
SCRATCH/hardcoded-ips-agent.md Normal file
View File

@ -0,0 +1,30 @@
# Hardcoded IPs in zlh-agent — Need to Fix
## Artifact server IP (10.60.0.251:8080) — ACTION REQUIRED
| File | Type | Fix |
|------|------|-----|
| internal/update/update.go:23 | **Compiled constant** | Code change + recompile required |
| internal/provision/common.go:35 | Fallback | Set ZLH_ARTIFACT_BASE_URL env var |
| internal/provcommon/common.go:59 | Fallback | Set ZLH_ARTIFACT_BASE_URL env var |
| scripts/devcontainer/lib/common.sh:16 | Default | Set ZLH_ARTIFACT_BASE_URL env var |
| scripts/devcontainer/dotnet/install.sh:10 | Default | Set ZLH_ARTIFACT_BASE_URL env var |
| scripts/addons/codeserver/install.sh:10 | Default | Set ZLH_ARTIFACT_BASE_URL env var |
## Action items
1. **Fix update.go:23** — change the hardcoded constant to read from an env var or config file
- This requires a code change and recompile
- New binary needs to be pushed to zlh-artifacts before deploying to containers
2. **Set ZLH_ARTIFACT_BASE_URL** — all other references will follow this env var
- Set to new artifacts IP once DHCP is locked down
## Localhost entries (safe — no changes needed)
- 127.0.0.1 in readiness.go, agent.go, update.go — internal health checks, fine
- 0.0.0.0 in codeserver install.sh + verify.go — bind address, fine
## Notes
- Until update.go is fixed, agent self-updates will try to reach old artifacts IP
- All new container provisioning uses ZLH_ARTIFACT_BASE_URL so that's fine once env is set
- Prioritize the update.go fix before deploying agent to production containers on new host